-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge encoding #15
base: main
Are you sure you want to change the base?
Edge encoding #15
Conversation
Also modified some doctests from expecting the PhyloNetworks. qualifier
I just saw that the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
…ons.jl into edge_encoding
Also removed the Project file in the test folder and tried to add them as in the main Project file. The only complication came from adding as a test-only dependency. I added the development version directly from url. However, when trying to remove SNaQ from I would get an error when running tests saying that it was expecting SNaQ to be registered. I think(?) this can be resolved by adding the main branch of SNaQ when those changes are finally pushed and registered.
I was working on the pull request for PhyloCoalSimulations and ending up fixing some of the tests as part of the process. I have those changes in the edge_encoding branch where there is a pull request. This branch also currently has the most up to date changes merged from the dev The only funky thing that I couldn't quite figure out was how to properly have SNaQ as a test-only dependency. I added the dev version of SNaQ as a dependency. It is only needed in the tests but whenever I try to remove it from [deps] in the Project file, I get the following error: |
It would be so much better to not depend on SNaQ, even for tests. |
I suppose it might depend on what all is included but if they are somewhat general utilities that come up in a few places, then perhaps they could go in I don't take huge issue with depending on SNaQ for only tests but I could see it being unideal in other cases where packages have it as a dependency for only the few CF-related functions. |
I thought that having a separate project file |
…; favor population_mappedto
I hope all checks will pass, with SNaQ removed from the package's dependencies (but included for tests). The documentation should pass after In my last commit, I exported the function I wonder the new function |
I agree. For now we can keep SNaQ as a dependency for tests. Independently, we can list the general utilities that come up in several places that don't need the |
I think perhaps we could combine both of those ideas into something like |
Let's wait until PhyloPlots v2.0 is released, then re-run the documentation to make sure it builds. I don't understand what's holding back the release of PhyloPlots... |
See previous pull request here. PR'ing form this branch for more public access to modify code