Figures in Juno not auto-scaled vertically

[zhouyan]

After recent updates, figures in the Plot panel inside Juno/Atom does not scale vertically automatically. It still scale to fill the width of the panel, but not the height.

I am actually not really sure if this is a problem with PlotlyJS, or WebIO, or Juno or Atom.jl. Any help to point to the right direction is appreciated

[ancapdev]

I'm seeing the same issue, auto-scales horizontally, but not vertically. Does anyone have any idea where it breaks?

Platform Windows 10

Atom 1.40.1, with

Ink 0.11.5
julia-client 0.11.2
uber-juno 0.3.0 

Julia 1.2.0, with:

Atom.jl 0.11.0
Blink.jl 0.12.0
Juno.jl 0.7.2
PlotlyJS 0.13.0
WebIO 0.8.11

[sglyon]

That's really strange. I'm not sure what would be causing this. I don't have time to dig into it now, but would be happy to review any pull requests that attempt to fix the issue

[ancapdev]

Do you have any ideas where might be a good place to start looking?

[sglyon]

the relevant code is in this file: https://github.com/sglyon/PlotlyJS.jl/blob/master/src/display.jl

It looks like we try to handle this here: https://github.com/sglyon/PlotlyJS.jl/blob/9869ff18f1cda79799e74491c31ca0a5a7058699/src/display.jl#L88-L94

But it must not be working

[ancapdev]

Thanks. I tried fiddling with this code after I hit the problem, but wasn't able to change the behavior. Thought the issue may be elsewhere.

[sglyon]

perhaps delete the if condition and run that code always?

[ancapdev]

That does fix it, thanks! I didn't even think of that 🤦‍♂