From 2a21f9801565ba340837ca2c9c9cafaaa16da710 Mon Sep 17 00:00:00 2001 From: James Foster Date: Fri, 1 Nov 2024 11:42:07 +1100 Subject: [PATCH 1/2] Avoid having implicit imports. --- src/PlotlyKaleido.jl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/PlotlyKaleido.jl b/src/PlotlyKaleido.jl index 1a2bc20..6b8b8fb 100644 --- a/src/PlotlyKaleido.jl +++ b/src/PlotlyKaleido.jl @@ -1,8 +1,8 @@ module PlotlyKaleido -using JSON: JSON -using Base64 -using Kaleido_jll +import JSON +import Base64 +import Kaleido_jll export savefig @@ -75,8 +75,8 @@ function start(; kwargs..., ) is_running() && return - # The kaleido executable must be ran from the artifact directory - BIN = Cmd(kaleido(); dir = Kaleido_jll.artifact_dir) + # The kaleido executable must be run from the artifact directory + BIN = Cmd(Kaleido_jll.kaleido(); dir = Kaleido_jll.artifact_dir) # We push the mandatory plotly flag push!(BIN.exec, "plotly") chromium_flags = ["--disable-gpu", Sys.isapple() ? "--single-process" : "--no-sandbox"] @@ -170,7 +170,7 @@ If the process was killed due to an error during initialization, you will receiv img = String(obj["result"]) # base64 decode if needed, otherwise transcode to vector of byte - bytes = format in TEXT_FORMATS ? transcode(UInt8, img) : base64decode(img) + bytes = format in TEXT_FORMATS ? transcode(UInt8, img) : Base64.base64decode(img) write(io, bytes) end From e37f5bd920447740aff072e5d1bcc5a537d2ecd2 Mon Sep 17 00:00:00 2001 From: James Foster Date: Thu, 7 Nov 2024 10:56:22 +1100 Subject: [PATCH 2/2] Change to explicit form. --- src/PlotlyKaleido.jl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/PlotlyKaleido.jl b/src/PlotlyKaleido.jl index 6b8b8fb..83f4804 100644 --- a/src/PlotlyKaleido.jl +++ b/src/PlotlyKaleido.jl @@ -1,8 +1,8 @@ module PlotlyKaleido -import JSON -import Base64 -import Kaleido_jll +using JSON: JSON +using Base64: Base64 +using Kaleido_jll: Kaleido_jll export savefig