Skip to content
This repository has been archived by the owner on Jun 29, 2021. It is now read-only.

Dealing with missing values in DataFrames #69

Open
asinghvi17 opened this issue Mar 28, 2019 · 2 comments
Open

Dealing with missing values in DataFrames #69

asinghvi17 opened this issue Mar 28, 2019 · 2 comments

Comments

@asinghvi17
Copy link
Member

Currently, missing values in DataFrames (or DataFrames with column datatypes Union{Any, Missing}) cause errors in StatsMakie. What would be the best way to deal with this?

I think the best solution would be to use DataFrames.jl's integrated disallowmissing or dropmissing method, but that may cause unexpected behaviour (to the user).

@mkborregaard
Copy link
Member

I don't think disallowmissing should be the first choice. missing values are part of Base Julia now, and they should be first-class citizens, treated mostly like NaNs.

@piever
Copy link
Member

piever commented Mar 28, 2019

I think there are two possible ways forward:

  1. Drop lines where one of the columns we use has a missing value (possibly with a warning)
  2. Same as option 1. except when the users uses categorical axes (meaning, where under the hood we replace categories with numbers from 1 to n and add ticks to the axes based on categorical values), in which case missing should have its own category

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants