Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Ipf v0.1.0 #105181

Closed

Conversation

JuliaRegistrator
Copy link
Contributor

- initial release of Ipf.ij, a lightweight package for providing allocation-free access to binary ESA/ESOC interpolation files.

UUID: dfb2dbec-0384-47ba-b614-66be42e3cf9e
Repo: https://github.com/andreapasquale94/Ipf.jl.git
Tree: 9dfa57550106babf1187318f2ccb71cee658fff2

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
JuliaRegistrator referenced this pull request in andreapasquale94/ESAInterpolationFiles.jl Apr 18, 2024
Copy link
Contributor

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Name is not at least 5 characters long
  • There is no compat entry for julia.
  • The following dependencies do not have a [compat] entry that is upper-bounded and only includes a finite number of breaking releases: PreallocationTools
  • No licenses detected in the package's top-level folder. An OSI-approved license is required.
  • Package name similar to 2 existing packages.
    1. Similar to ISL. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    2. Similar to ITK. Damerau-Levenshtein distance 2 is at or below cutoff of 2.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the Julia Slack to ask for help. Include a link to this pull request.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Apr 18, 2024

I'd actually recommend just naming this package ESAInterpolationFiles. You might be able to get away with something like IPFFiles, but there really isn't any reason not to go for a maximally descriptive package name. It would still export IPF, so your example would just be

using ESAInterpolationFiles
# or (I think unqualified imports are a bad idea in general):
# using ESAInterpolationFiles: IDF, compute, compute_derivative

# Load an IPF file
file = IPF("example.ipf")

# Compute interpolated value for a given key
value = compute(file, 10.5)

# Compute derivative for a given key
derivative = compute_derivative(file, 10.5)

which seems perfectly nice and readable.

@andreapasquale94
Copy link

Thank you for the suggestions, I would rather not use ESA in the package name as this is not affiliated with the Agency.
I will go ahead and apply the required changes by the auto-merge and change the name to IPFiles.jl.

@goerz
Copy link
Member

goerz commented Apr 22, 2024

I would rather not use ESA in the package name as this is not affiliated with the Agency

I don't think there would be any issue with that. The package deals with "ESA Interpolation Files", so the file format is associated with ESA, but that does not imply that your package is, or that you can't use the name of the format as part of your package.

I will go ahead and apply the required changes by the auto-merge and change the name to IPFiles.jl

Yeah, IPFFiles.jl (two F's, as following the pattern <FileExtension>Files.jl) is probably OK, although there is also the Interchangeable Preservation Format (which ranks higher in Google), which is not ideal.

@andreapasquale94
Copy link

Another PR has been opened with the required changes, therefore this can be closed.

@goerz goerz closed this May 2, 2024
@DilumAluthge DilumAluthge deleted the registrator-ipf-dfb2dbec-v0.1.0-e87f6ca3b1 branch May 5, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants