-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: CryptographicHashFunctions v0.0.1 #105373
New package: CryptographicHashFunctions v0.0.1 #105373
Conversation
JuliaRegistrator
commented
Apr 22, 2024
- Registering package: CryptographicHashFunctions
- Repository: https://github.com/erich-9/CryptographicHashFunctions.jl
- Created by: @erich-9
- Version: v0.0.1
- Commit: b90ee62685e1463fb0aac01ecfc0bf2da8d29fd9
- Reviewed by: @erich-9
- Reference: erich-9/CryptographicHashFunctions.jl@b90ee62#commitcomment-141228010
- Description: Fast cryptographic hash functions for Julia
UUID: 59f36028-7e5a-47c1-b5da-23e00bab95ae Repo: https://github.com/erich-9/CryptographicHashFunctions.jl.git Tree: 12724ea5543355dde0ee4ad902e4e7b81079366c Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Your Since you are registering a new package, please make sure that you have read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text |
What is the scope of this package in relation to the existing packages, e.g. in JuliaCrypto ? It seems a substantial part of this package is wrappers (which should be named accordingly)? [noblock] |
Yes, for now it's all wrappers. But isn't this an implementation detail? Why would they require special naming? The scope is convenience. Recently, I needed fast SHA-3 functions. Since the ones provided by [noblock] |
@stemann Since your comment is blocking the merge, do you expect me to make any changes? [noblock] |
I have not looked much at cryptography in Julia, but it seems Nettle.jl and SEAL.jl follow the common practice of having one Julia wrapper package per binary dependency (JLL) - in line with the naming guidelines, point 6: Packages that wrap external libraries or programs should be named after those libraries or programs. The discussion in JuliaCrypto/SHA.jl#90 (comment) also argues for wrappers in separate packages (e.g. a HACL* wrapper). This packages wraps two binaries. CryptographicHashFunctions is a quite general name - hence the question to scope. Is this package or does it strive to be the canonical (pure Julia) interface to cryptographic hash functions? … there is also already OpenSSL.jl - which probably should wrap OpenSSL JLL: JuliaCrypto/OpenSSH.jl#1 [noblock] |
This place is already taken by Basically this package is the would-be package @stemann Do you see any way to solve the issue without including the name of wrapped packages? Would another name be okay for you (e.g. [noblock] |
I think this has had enough consideration from my side - unblocking my comments. [noblock] |