Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IndividualDisplacements URL to post-rename repo #119150

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

gaelforget
Copy link
Contributor

No description provided.

@gaelforget
Copy link
Contributor Author

See #119126

@gaelforget
Copy link
Contributor Author

I do not understand why Merging is blocked.

@gaelforget
Copy link
Contributor Author

I opened this PR because https://github.com/JuliaRegistries/General#readme says

if you rename the repository so it has a new URL, make a PR to edit the URL stored in the registry for the old package name to point to the new URL ([example](https://github.com/JuliaRegistries/General/pull/40190/files)). This allows the old versions of the package under the previous name to continue to work.

and it seems desirable that previous name continues to work.

Did I do something wrong?

@GunnarFarneback
Copy link
Contributor

I do not understand why Merging is blocked.

That's the same for all PRs to General unless you happen to have merge authorization.

Did I do something wrong?

This PR looks fine to me but since it is a manual PR, automerge doesn't handle it and it needs to be merged by someone who does have merge authorization.

@gaelforget
Copy link
Contributor Author

I do not understand why Merging is blocked.

That's the same for all PRs to General unless you happen to have merge authorization.

Did I do something wrong?

This PR looks fine to me but since it is a manual PR, automerge doesn't handle it and it needs to be merged by someone who does have merge authorization.

Makes sense now. Thanks for the clarification

@gaelforget
Copy link
Contributor Author

Hi. Could this get merged?

@fredrikekre fredrikekre merged commit 2f57b7f into JuliaRegistries:master Nov 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants