-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: PRASInterface v0.1.0 #120021
New package: PRASInterface v0.1.0 #120021
Conversation
JuliaRegistrator
commented
Nov 22, 2024
•
edited
Loading
edited
- Registering package: PRASInterface
- Repository: https://github.com/NREL-Sienna/PRASInterface.jl
- Created by: @jd-lara
- Version: v0.1.0
- Commit: dcb927a69268e3a776172e4c1c5d8bc83bfadaf2
- Reviewed by: @jd-lara
- Reference: NREL-Sienna/SiennaPRASInterface.jl@dcb927a#commitcomment-149447558
- Description: Interface to PRAS.jl maintained by Sienna\Ops
* Update README.md * Update main-tests.yml * Update pr_testing.yml * Update Project.toml
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human. 1. New package registrationPlease make sure that you have read the package naming guidelines. 2. AutoMerge Guidelines are all met! ✅Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. 3. To pause or stop registrationIf you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text Tip: You can edit blocking comments to add |
Thank you for submitting your package! However, please make sure to add some documentation before registering. At the very least, that would be a description of the package's purpose and a small usage example in the README. It's not clear to me whether the name of the package is appropriate. I was not able to find the |
Update: I was now able to guess at the URL for the documentation https://nrel-sienna.github.io/PRASInterface.jl/dev/ Please note that the docs badge in the README is currently broken. That will probably resolve itself once this registration goes through and there is a tagged version, but please confirm that it works at that point. You'll also want to add the "About" info from the documentation to the main README. Now that I've seen the documentation, I would recommend the package name |
Thanks for the comments @goerz, on the name we would like to keep the existing one since it is an interface to this package https://github.com/NREL/PRAS that isn't own directly by us. This package is an interface between our data library PowerSystems.jl and PRAS that's where the names comes from. The difference is that the authors of PRAS decided not to register it in the general Julia registry. I will update the README and the registration request. |
UUID: 4b496c86-8d00-441d-b504-079c710e0aa7 Repo: https://github.com/NREL-Sienna/PRASInterface.jl.git Tree: 76f8abe5d6a11c3067e295a2433d15393f3bc5a0 Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
784b2ef
to
42ebc48
Compare
Thanks for updating the README!
Like I said, I don't think the name Of course, I don't have any special authority, so you could also ask for other people's opinion on Slack. If there's a broad consensus in the community that the name is okay, I'll be happy to unblock. |
The objection is that PowerSystemsPRAS doesn't reflect the true usage of this library, if we develop our own Probabilistic Resource Adequacy capability then there will be name confusion. This is not the correct package convention in our organization. The name we want to use is reflective of what the package actually does: an interface to PRAS.jl, similarly we registered in the past PowerModelsInterface.jl. It's an interface between our data model and another Julia modeling library period. The difference is that in the case of PRAS.jl, a common library for users in the Resource Adequacy space, our team doesn't have the mechanism to make the authors register it to General. I don't understand the need to request community feedback for the registration of this package that follows the conventions of our organization that already have plenty of registered packages in the power systems modeling space. |
I think it is important to note that the name
so the fact that PRASInterface.jl is related to PRAS.jl is kind of irrelevant because PRAS.jl only exists in a private registry. On another note, I'm wondering if this should be a package extension rather than a standalone? it seems like the functionality here only exists in the context of PowerSystem.jl and PRAS.jl together, and it does not have any function as an independent package. |
Maybe I'm confused. An interface between PRAS and what else? Whatever that "what else" is should be part of the package name. I thought this package was an Interface between
At the time that was registered, there weren't as many volunteers reviewing package submissions. Thus, things slipped through the cracks. The name
The General registry is a community resource, so all registrations will be reviewed
You are moving a package from the context of a specific organization to the General registry that addresses the entire community. For people internal to NREL-Sienna the name P.S.: Just reread your original response
So I didn't just make this up. If what you say is true, there is no question that |
Yes, or at least it would receive some pushback. I'm actually not sure how exactly It does seem like a problem to have a registered package interfacing with It would be good for @GordStephen to clarify what kind of plans there might be for a registration of Side node: if PRAS ever were registered, even if we make an exception for the name (which we very well might), the repository URL has to be changed to end with |
I can get behind using BTW, reading your reponse I have to feedback that comments like "So I didn't just make this up. If what you say is true, there is no question that PowerSystemsPRAS is pretty much the only correct name for the package." aren't really a suggestion. |
@goerz please avoid statements like:
You do not decide the "only correct name" for a package. While you correctly state that you are not the final arbiter of names here, your tone and frequency of activity often suggests otherwise. Statements like this are far too aggressive, and factually incorrect. Please maintain a more conciliatory and suggesting rather than demanding tone. The registry is an initial point of contact for many users and groups in the Julia community, and the tone of naming disputes like this one is a source of frequent complaints directed to me and other folks in community facing roles. Remember that by helping to maintain our naming guidelines you are representing the Julia community which we want to be a welcoming, kind place. Since the author has agreed to a potential alternative name I will not rebut any of the other statements, and support their bid to use that name. [noblock] |
@rayegun Point taken. That phrasing was indeed out of line. I apologize. |
We talked this out on Slack. @jd-lara will check to see if renaming to |
This PR can be closed given #120172 |