Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: GridMaps v0.1.0 #120225

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Nov 26, 2024

The first release of the GridMaps package. Provides a simple type for mapping values over rectangular grids.

UUID: 889a5e0-cea4-48d1-aea6-4a3fe9168d86
Repo: https://github.com/ngharrison/GridMaps.jl.git
Tree: 25e266069b9e75ad928ba1b8d1c752678a9988d2

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

github-actions bot commented Nov 26, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@ngharrison
Copy link

ngharrison commented Nov 26, 2024

Cancel this please.

[noblock]

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Nov 26, 2024
@goerz
Copy link
Member

goerz commented Nov 26, 2024

Closing in favor of #120233

For what it's worth, these "name similarity" checks are usually false positives, and can be easily overridden. GridMaps would definitely have been okay with respect to Gridap

[noblock]

@goerz goerz closed this Nov 26, 2024
@ngharrison
Copy link

ngharrison commented Nov 26, 2024

@goerz Thank you. Good to know since this is the first time I've tried registering a package. How does the override work? Is that something I do or on the General registry admin side?

In the case of this package I'm trying to register, I would happily roll it back to the previous name since it aligns more with Julia package naming conventions.

[noblock]

@goerz
Copy link
Member

goerz commented Nov 26, 2024

Is that something I do or on the General registry admin side?

It’s on the admin side. Anyone who is at least a “triage member” (that would be me) can set it

In the case of this package I'm trying to register, I would happily roll it back to the previous name since it aligns more with Julia package naming conventions.

That would be fine. I think we actually could just reopen this PR, but then you should roll back the rename on the repo first. Or make a new registration PR, it doesn’t matter that much.

[noblock]

@ngharrison
Copy link

ngharrison commented Nov 26, 2024

Ok, I've reset the name back and we can close the other pull request in favor of this one. Thanks again for your help.

[noblock]

@goerz
Copy link
Member

goerz commented Nov 26, 2024

[noblock] Ok, hopefully this will work, then.

We both have to edit all of our comments to contain [noblock] as well

@JuliaTagBot JuliaTagBot removed the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Nov 26, 2024
@JuliaTagBot JuliaTagBot merged commit 9d419bf into master Nov 29, 2024
26 of 28 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-gridmaps-889a5e0f-v0.1.0-79b52365e9 branch November 29, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants