Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: JuMag v0.3.0 #105307

Closed

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 8b6b6816-cea2-582c-a99f-83810c20db0f
Repo: https://github.com/ww1g11/JuMag.jl.git
Tree: b33798ecdb3d9671dffe336c27632467dcf61594

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Package name starts with "Ju".
  • There is no compat entry for julia.
  • The following dependencies do not have a [compat] entry that is upper-bounded and only includes a finite number of breaking releases: FFTW, JLD2, KernelAbstractions, ReadVTK, TimerOutputs, WriteVTK
  • Package name similar to 2 existing packages.
    1. Similar to Julog. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    2. Similar to JuMP. Damerau-Levenshtein distance 2 is at or below cutoff of 2.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simply retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the Julia Slack to ask for help. Include a link to this pull request.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://pkgdocs.julialang.org/v1/creating-packages/#Package-naming-guidelines


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment. You can edit blocking comments, adding [noblock] to them in order to unblock auto-merging.

@goerz
Copy link
Member

goerz commented Apr 21, 2024

This looks like a very nice package, but I think you should try to find a better name without the Ju prefix (unless you can come up with an explanation where Ju doesn’t stand for “Julia”). Long and descriptive names are usually encouraged, but if you can find a nice “clever” name, that can work too.

BTW, it looks like you are trying to have some bibliographic references in the documentation. You might find the DocumenterCitations plugin useful for that.

@ww1g11
Copy link
Contributor

ww1g11 commented Apr 21, 2024

This looks like a very nice package, but I think you should try to find a better name without the Ju prefix (unless you can come up with an explanation where Ju doesn’t stand for “Julia”). Long and descriptive names are usually encouraged, but if you can find a nice “clever” name, that can work too.

BTW, it looks like you are trying to have some bibliographic references in the documentation. You might find the DocumenterCitations plugin useful for that.

Hi Michael,

Thank you for the suggestion. However, we began this project 5 years ago, and it has already been cited in some publications, for
instance, [https://arxiv.org/abs/1906.00648]. Therefore, if possible, we would prefer not to change its name.

It seems that DocumenterCitations.jl is very helpful, we will use it in our project.

Best,
Weiwei

@goerz
Copy link
Member

goerz commented Apr 21, 2024

Unfortunately, it's not up to me. Only a full registry maintainer can override the rule for the Ju prefix. But you really shouldn't publish papers about an unregistered package. If I were a maintainer, I would not be inclined to make exceptions based on that: It's pretty unfair to other registrations. Note that if you rename the package, the link in paper will still work. GitHub automatically forwards the URLs for renamed repositories.

@goerz
Copy link
Member

goerz commented Apr 21, 2024

I mean, the name probably isn’t an absolute no-go. If you really want to keep it, you can make the argument in the Slack channel, and see if there’s a maintainer willing to merge, after the three-day period.

@ww1g11
Copy link
Contributor

ww1g11 commented Apr 21, 2024

Unfortunately, it's not up to me. Only a full registry maintainer can override the rule for the Ju prefix. But you really shouldn't publish papers about an unregistered package. If I were a maintainer, I would not be inclined to make exceptions based on that: It's pretty unfair to other registrations. Note that if you rename the package, the link in paper will still work. GitHub automatically forwards the URLs for renamed repositories.

I hope the package will merged automatically rather than manually, so I will follow the auto-merging rules. I am not sure if the link will work after renaming, but I guess I can create a new package.

@goerz
Copy link
Member

goerz commented Apr 21, 2024

You can follow the steps in the FAQ. Definitely use the GitHub rename feature. This will ensure that any link to the old repository will forward to the new name.

When you register the renamed package, it will create a new registration PR. Leave a comment here pointing to that new PR, and then we close this here.

@ww1g11
Copy link
Contributor

ww1g11 commented Apr 22, 2024

You can follow the steps in the FAQ. Definitely use the GitHub rename feature. This will ensure that any link to the old repository will forward to the new name.

When you register the renamed package, it will create a new registration PR. Leave a comment here pointing to that new PR, and then we close this here.

Thank you so much. I tried my best and can not think of a better name than JuMag, so I gave up registering it, please close this PR.

@goerz
Copy link
Member

goerz commented Apr 22, 2024

Ok… maybe just give it a bit of time. As I said, this looks like a nice package, so if you can come up with a suitable name, it would be great to see it registered.

@goerz goerz closed this Apr 22, 2024
@DilumAluthge DilumAluthge deleted the registrator-jumag-8b6b6816-v0.3.0-44ccbcc622 branch May 5, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants