Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: MCPSolver v0.1.0 #120271

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 6c9e26cb-9263-41b8-a6c6-f4ca104ccdcd
Repo: https://github.com/CLeARoboticsLab/MCPSolver.jl.git
Tree: 0ba06ab6c14a512e9dc0c0ac4e381f0b948c4bbb

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@gdalle
Copy link
Contributor

gdalle commented Nov 27, 2024

Hi, congrats on the package! Since the acronym is not standard, can I suggest the name MixedComplementarityProblems.jl?

@dfridovi
Copy link

If possible, I'd like to keep it with the MCP acronym for two reasons. First, my sense is that this is one of two standard acronyms in the OR community for these problems (the other being MiCP) - cf. the textbook from Facchinei and Pang here. Second, I am basing this package off of ParametricMCPs, and the naming scheme should probably be consistent. Thoughts?

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Nov 27, 2024
Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines which are not met ❌

  • There is no compat entry for julia.
  • Package name similar to 2 existing packages.
    1. Similar to DCISolver. Damerau-Levenshtein distance 2 is at or below cutoff of 2.
    2. Similar to MPSolve. Damerau-Levenshtein distance 2 is at or below cutoff of 2.

3. Needs action: here's what to do next

  1. Please try to update your package to conform to these guidelines. The General registry's README has an FAQ that can help figure out how to do so.
  2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless the AutoMerge issue is that you skipped a version number).

If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the public Julia Slack for better visibility.

4. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@gdalle
Copy link
Contributor

gdalle commented Nov 27, 2024

I understand your concerns.

First, my sense is that this is one of two standard acronyms in the OR community for these problems

The reason behind my suggestion is that acronyms like this are only standard in one specific community, in this case OR. I also belong to that community and the acronym wasn't even obvious to me. It is never hurtful to have a longer package name. For instance, I developped a package called HiddenMarkovModels.jl and I didn't call it HMM.jl even though the abbreviation is pretty standard too. The only spelled out word in your package name is "Solver", and it is a pretty generic one.

Second, I am basing this package off of ParametricMCPs, and the naming scheme should probably be consistent.

That is a more valid reason, although I would also have objected to the registration of ParametricMCPs.jl for the same reasons.

@dfridovi
Copy link

Fair enough. I'll change it to something like MixedComplementarityProblems.jl per your initial suggestion.

@dfridovi
Copy link

dfridovi commented Nov 27, 2024

Ok package is renamed as requested.

@gdalle
Copy link
Contributor

gdalle commented Nov 27, 2024

Thanks!

@goerz
Copy link
Member

goerz commented Nov 27, 2024

Closing in favor of #120277

@goerz goerz closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants