From eeed483a04690266e50eefcd7a04dd6828340703 Mon Sep 17 00:00:00 2001 From: Twan Koolen Date: Tue, 19 Sep 2017 14:37:41 -0400 Subject: [PATCH 1/2] Add deprecations for removed functions. --- src/spatial/Spatial.jl | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/spatial/Spatial.jl b/src/spatial/Spatial.jl index 9942c372..4f21e69d 100644 --- a/src/spatial/Spatial.jl +++ b/src/spatial/Spatial.jl @@ -58,4 +58,13 @@ include("spatialmotion.jl") include("spatialforce.jl") include("motion_force_interaction.jl") +# deprecations +export + invtransform, + num_cols + +Base.@deprecate invtransform(x::Point3D, t::Transform3D) t \ x +Base.@deprecate invtransform(x::FreeVector3D, t::Transform3D) t \ x +Base.@deprecate num_cols(x::Union{<:GeometricJacobian, <:MomentumMatrix, <:WrenchMatrix}) size(x, 2) + end # module From 77643f8c5c10602cc7ea34a079955257a8318871 Mon Sep 17 00:00:00 2001 From: Twan Koolen Date: Tue, 19 Sep 2017 14:37:55 -0400 Subject: [PATCH 2/2] Point to DiffBase PR. --- test/runtests.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/runtests.jl b/test/runtests.jl index 9fd55fba..971206f5 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -12,7 +12,7 @@ import Base.Iterators: filter # useful utility function for computing time derivatives. create_autodiff(x, dx) = [ForwardDiff.Dual(x[i], dx[i]) for i in 1 : length(x)] -# TODO: open a PR with ForwardDiff: +# TODO: https://github.com/JuliaDiff/DiffBase.jl/pull/19 @inline Base.mod2pi(x::ForwardDiff.Dual) = ForwardDiff.Dual(mod2pi(ForwardDiff.value(x)), ForwardDiff.partials(x)) @inline Base.rem(x::ForwardDiff.Dual, n::Real) = ForwardDiff.Dual(rem(ForwardDiff.value(x), n), ForwardDiff.partials(x)) @inline Base.rem2pi(x::ForwardDiff.Dual, roundingmode::RoundingMode) = ForwardDiff.Dual(rem2pi(ForwardDiff.value(x), roundingmode), ForwardDiff.partials(x))