Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove automatic inbounds stuff #43

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Conversation

MasonProtter
Copy link
Contributor

@MasonProtter MasonProtter commented Oct 9, 2023

Ref: JuliaSIMD/StrideArrays.jl#80

This PR takes the approach of just nuking the StrideArraysCore.checkbounds function entirely. If preferred though, I can change it so that it still exists but befaults to true.

Another thing we could do to avoid making this a breaking release is we could just define a stub

function checkbounds end

so that code in other packages that try and turn boundschecks on or off continues to function


Note: I haven't yet done any sort of audit yet to see if there are functions or chunks of code which could safely be marked inbounds but currently aren't due to the default being no bounds checks.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7131c89) 62.14% compared to head (483d849) 62.10%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   62.14%   62.10%   -0.04%     
==========================================
  Files           7        7              
  Lines         803      797       -6     
==========================================
- Hits          499      495       -4     
+ Misses        304      302       -2     
Files Coverage Δ
src/StrideArraysCore.jl 100.00% <ø> (ø)
src/ptr_array.jl 73.36% <100.00%> (+0.30%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chriselrod chriselrod merged commit 0b174fb into JuliaSIMD:main Oct 9, 2023
@chriselrod
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants