Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: JuliaSIMD/StrideArrays.jl#80
This PR takes the approach of just nuking the
StrideArraysCore.checkbounds
function entirely. If preferred though, I can change it so that it still exists but befaults totrue
.Another thing we could do to avoid making this a breaking release is we could just define a stub
so that code in other packages that try and turn boundschecks on or off continues to function
Note: I haven't yet done any sort of audit yet to see if there are functions or chunks of code which could safely be marked inbounds but currently aren't due to the default being no bounds checks.