Generate bindings for each target #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmmm, yeah, I agree we should do the platform specific generated code. I wonder if there's a relatively simple way we could only put truly platform-specific code in the individual platform files and share the other 99%, partly to avoid needing to commit 145K lines of code 😬 |
quinnj
reviewed
Mar 25, 2024
Octogonapus
force-pushed
the
handle_all_targets
branch
from
7e43de0 to
f3527b9
Compare
|
@quinnj This is RTM for me. I had to ignore some ITT API symbols that aren't useful to us. |
quinnj
reviewed
Apr 3, 2024
gen/Manifest.toml
Outdated
| uuid = "73048d1d-b8c4-5092-a58d-866c5e8d1e50" | ||
| version = "0.9.14+0" | ||
| version = "0.9.3+1" |
There was a problem hiding this comment.
looks like this slipped back again
There was a problem hiding this comment.
Ok, I bumped it back up and re-ran the generation, which was good for me to try out locally anyway.
There was a problem hiding this comment.
Thanks, not sure how that happened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I understand it, we need to generate bindings per-target because the JLL contains header files per-target and they could differ.
I would rather be safe than sorry.