Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ftol_rel should be a small number, not a large number, right? #713

Closed
dmbates opened this issue Sep 8, 2023 · 1 comment · Fixed by #714
Closed

The ftol_rel should be a small number, not a large number, right? #713

dmbates opened this issue Sep 8, 2023 · 1 comment · Fixed by #714

Comments

@dmbates
Copy link
Collaborator

dmbates commented Sep 8, 2023

MixedModels.jl/src/bootstrap.jl

Line 183 in 9ee4a0a

fit during the bootstrapping process. For example, `optsum_overrides=(;ftol_rel=1e08)`

Should the new value of ftol_rel be 1e-8, not 1e08?
@palday
Copy link
Member

palday commented Sep 8, 2023

Oh that's a bad typo indeed - it should be a small number!

@palday palday mentioned this issue Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix typo that changes scale JuliaStats/MixedModels.jl
2 participants
@dmbates @palday