Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for ExplicitImports check #765

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Update for ExplicitImports check #765

merged 1 commit into from
Apr 28, 2024

Conversation

dmbates
Copy link
Collaborator

@dmbates dmbates commented Apr 27, 2024

Thanks for contributing!

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

Some of the names listed for explicit imports are no longer needed. I think this can be regarded as an internal change.

@dmbates dmbates requested a review from palday April 27, 2024 14:58
Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93%. Comparing base (de39654) to head (55d10e5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #765   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files          34       34           
  Lines        3358     3358           
=======================================
  Hits         3255     3255           
  Misses        103      103           
Flag Coverage Δ
current 96.87% <ø> (ø)
minimum 96.83% <ø> (ø)
nightly 96.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmbates dmbates merged commit d250426 into main Apr 28, 2024
12 checks passed
@dmbates dmbates deleted the db/ExplicitImports branch April 28, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants