Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt executiom module junos.install_os with dev_timout fails with Installation failed due to: "pkgadd() got multiple values for keyword argument 'dev_timeout'" #117

Closed
rsmekala opened this issue Apr 25, 2019 · 1 comment

Comments

@rsmekala
Copy link

Description of Issue/Question

root@olympics-salt:/srv/pillar# salt "vmx1" junos.install_os salt://junos-install-mx-x86-64-19.3I-20190409_dev_common.0.2212.tgz no_copy=False reboot=True dev_timeout=400

vmx1:
    ----------
    message:
        Installation failed due to: "pkgadd() got multiple values for keyword argument 'dev_timeout'"
    out:
        False

Caused by #116. dev_timeout is still present in __pub_arg, causing the above error.

@rsmekala rsmekala self-assigned this Apr 25, 2019
rsmekala pushed a commit to rsmekala/salt that referenced this issue Apr 25, 2019
rsmekala pushed a commit to rsmekala/salt that referenced this issue Apr 25, 2019
@rsmekala
Copy link
Author

Will track the issue using #115.

vnitinv added a commit that referenced this issue May 13, 2020
* Merged junos-specific changes on 2019.2

* Merged junos-specific changes on 2019.2

* Fixes FileNotFound exception with invalid dest option in junos.cli

* Fixed documentation for junos.diff

* Fixed improper handling of dest and format options in rpc modules

* Implement exception handling around XML filter parsing

* Porting fix from develop to 2019.2

* Fixed documentation

* Fixed documentation

* Fixed rollback docstring: CLI example

* Implemented exception handling around template rendering in junos.load

* Implemented exception handling around template rendering in junos.install_config

* Fixes broken state module junos.diff

* Fixes broken state module junos.rollback

* Fixes broken state module junos.rpc

* Adds documentation about zeroize functionality for non-root user

* Adds error message for install_config in case invalid mode provided

* Handle LockError case in install_config gracefully

* Replace string concatenation with format

* Revert replacing cli command with rpc: junos.zeroize

* Support dynamic config mode

* Changed CLI example to conform with new rpc module definition

* Added exception handling for invalid image path for install_os module

* Extended load() support to config_action:merge, to match PyEZ capabilities

* Added check to allow only 1 config_action in load()

* Fixed reboot=True scenario for install_os

* Added comments to explain the behaviour in reboot scenario

* Added new option all_re. Updated documentation

* Fixed #117

* Temporary fix for #117

* Modified as per review comments

* Fixes junos.load template case

* Fixed test cases in 2019.2 branch

* Update junos_syslog.py

* Use cache_file instead of get_file

* Revert "Use cache_file instead of get_file"

This reverts commit b679c06.

* Revert "Use cache_file instead of get_file"

This reverts commit b679c06.

* added new testcases

* code changes as per review comment by @twangboy

* code changes as per review comment by @twangboy

* fix lint warnings as per saltpylint

* fix pylint, pydoc, and test failures due to junos-eznc version

* Revert "fix pylint, pydoc, and test failures due to junos-eznc version"

This reverts commit 430d5bd.

* Revert "Revert "fix pylint, pydoc, and test failures due to junos-eznc version""

This reverts commit 4e69ce7.

* Revert "fix pylint, pydoc, and test failures due to junos-eznc version"

This reverts commit 430d5bd.

* working on fixing comments from saltstack unit runs

* fix: salt.states.junos.rst:20:Pygments lexer name 'set' is not known

* fix as per comment from @dmurphy18 and pre-commit changes

* import line changes as per pre-commit

* changes as per comment from salt team regarding interface syntax

* changes as per comment from salt team regarding interface syntax

* when called from junos.rpc from test, dest is intacct

* pre-commit checks for darwin

* pre-commit check for linux onf py 3.8 and 3.9

Co-authored-by: rsmekala <[email protected]>
Co-authored-by: Nitin Kr <[email protected]>
Co-authored-by: Nitin Kr <[email protected]>
Co-authored-by: Shane Lee <[email protected]>
Co-authored-by: Sage the Rage <[email protected]>
Co-authored-by: David Murphy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant