You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, dependsOn determines when one step needs another step to run before it which is useful for how we currently write our integrations. I have noticed a few times where a step that other steps dependsOn fails, it continues to run the dependent steps which will inevitably fail.
If a step truly dependsOn another, it should know if it failed or succeeded to determine whether it should run or not.
In a case I see in Knowbe4, the fetch-users and fetch-training-camps steps dependsOn the fetch-groups step. When fetch-groups fails, it causes the other 2 to fail since they are looking for a map with relevant data. There are some workarounds to solve this such as:
Set the fetch-groups step to be fatal so the integration terminates. This may not be ideal as there are other steps which don't care about groups.
In this case, you could simply do a check to see if the map it expects has any data and if so run it, otherwise skip over everything. This could work but in my opinion isn't the cleanest.
This would require us to keep track of the status of each step to check against.
The text was updated successfully, but these errors were encountered:
Currently,
dependsOn
determines when one step needs another step to run before it which is useful for how we currently write our integrations. I have noticed a few times where a step that other stepsdependsOn
fails, it continues to run the dependent steps which will inevitably fail.If a step truly
dependsOn
another, it should know if it failed or succeeded to determine whether it should run or not.In a case I see in Knowbe4, the
fetch-users
andfetch-training-camps
stepsdependsOn
thefetch-groups
step. Whenfetch-groups
fails, it causes the other 2 to fail since they are looking for a map with relevant data. There are some workarounds to solve this such as:fetch-groups
step to be fatal so the integration terminates. This may not be ideal as there are other steps which don't care about groups.This would require us to keep track of the status of each step to check against.
The text was updated successfully, but these errors were encountered: