Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change InternalException to InternalError #801

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change InternalException to InternalError #801

wants to merge 1 commit into from
+47 −31

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Nov 22, 2024

When an unrecoverable internal failure occurs, a sub-class of Error is more appropriate:

indicates serious problems that a reasonable application should not try to catch

This is inline with kotlinx.coroutines' approach, whereas CoroutinesInternalError is a sub-class of Error and also asks their library consumers to report the issue.

Closes #789

@twyatt twyatt added the major Changes that should bump the MAJOR version number label Nov 22, 2024
@twyatt twyatt requested a review from a team as a code owner November 22, 2024 18:14
@twyatt twyatt added this to the 0.35.0 milestone Nov 22, 2024
@twyatt twyatt mentioned this pull request Nov 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdonn3 sdonn3 Awaiting requested review from sdonn3 sdonn3 is a code owner automatically assigned from JuulLabs/conx-kotlin-reviewers

@QuantumRand QuantumRand Awaiting requested review from QuantumRand QuantumRand is a code owner automatically assigned from JuulLabs/conx-kotlin-reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
major Changes that should bump the MAJOR version number
Projects
None yet
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.

[Feedback 0.35.0-RC]: Scanner doesn't show in its description that the InternalException can be thrown
1 participant
@twyatt