Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feedback 0.35.0-RC]: Peripheral Constructor should allow address #790

Open
PavlosTze opened this issue Nov 12, 2024 · 1 comment · May be fixed by #803
Open

[Feedback 0.35.0-RC]: Peripheral Constructor should allow address #790

PavlosTze opened this issue Nov 12, 2024 · 1 comment · May be fixed by #803
Milestone
0.35.0

Comments

@PavlosTze
Copy link
Contributor

With 0.34.0 it was possible to create a Peripheral based on the MAC Address of the advertisement. If there is no specific reason of removing this functionality in 0.35.0, I suggest to include it as well as it's easier to not having to carry an Advertisement object but carry just a String throughout our app.
@PavlosTze PavlosTze changed the title [Feedback: 0.35.0-RC]: Peripheral Constructor should allow address [Feedback 0.35.0-RC]: Peripheral Constructor should allow address Nov 12, 2024
@twyatt twyatt added this to the 0.35.0 milestone Nov 12, 2024
@twyatt
Copy link
Member

twyatt commented Nov 26, 2024 •
edited
Loading

It was an oversight that it was removed. Thanks for catching that. It will be back in 0.35.0-rc2.

@twyatt twyatt linked a pull request Nov 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.35.0
Development

Successfully merging a pull request may close this issue.

Provide Peripheral(Identifier) builder function JuulLabs/kable
2 participants
@twyatt @PavlosTze