Fix hard-coding of LINKER variable. #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now LINKER uses the value of CXX. At the same time, I introduced use of the standard LEX and YACC variables.
In my experience, this is too stringent. I find it breaks the build even on cosmetic errors like "misleading indentation." Inclined to think that this should change to be an option for active developers only, and left off for users.
|
If you get a chance, it would be nice to get PR merged. |
|
Dear VAL supporters. We've recently managed to re-merge a large fork (see #42) and in the process resolved many popular requests, did a major clean-up and made things ready for continuous integration, which will help us safely service future pull requests. We've also setup a build pipeline to democratize binaries for Linux, Windows and MacOS users. We understand that resolving merge conflicts in your forks may be difficult and will cause some short term pain, but we believe this is a good investment for the future of the project and hope to see your future contributions into this cleaned-up codebase! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix issue #4
Now LINKER uses the value of CXX.
At the same time, I introduced use of the standard LEX and YACC variables.