Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models for query parameters #18

Open
mo-lukecarr opened this issue Dec 18, 2024 · 0 comments
Open

Models for query parameters #18

mo-lukecarr opened this issue Dec 18, 2024 · 0 comments

Comments

@mo-lukecarr
Copy link

mo-lukecarr commented Dec 18, 2024

Are there any plans to offer Pydantic models for the different query parameters supported by each query resource/type?

In my mind, having models for these query parameters will make it simpler to validate request URLs for query endpoints when implementing an EDR API (for example, FastAPI supports using a single Pydantic model to validate query params).

I'm happy to crack on with implementing this in a PR, but wanted to check in first by raising an issue. Also, I'm slightly confused around the variables.py file. Are these models the same as the query parameters, or a different part of the EDR specification (but confusingly sharing fields with similar names)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant