Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code generation for large screen preview #169

Closed
Kaaveh opened this issue Oct 30, 2023 · 6 comments
Closed

Code generation for large screen preview #169

Kaaveh opened this issue Oct 30, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Kaaveh
Copy link
Owner

Kaaveh commented Oct 30, 2023

According to our conversion in #166

@Kaaveh Kaaveh added the enhancement New feature or request label Oct 30, 2023
@Kaaveh Kaaveh moved this to Todo in Compose news Oct 30, 2023
@mhmd-android
Copy link
Contributor

Hi, I'm here to take it 🤚

@Kaaveh
Copy link
Owner Author

Kaaveh commented Jan 28, 2024

Hey @mhmd-android,
Do you have any updates on this task?

@mhmd-android
Copy link
Contributor

Hey @Kaaveh
Unfortunately, I didn't have enough time to work on this issue, but I will definitely take care of it as soon as possible

@Kaaveh
Copy link
Owner Author

Kaaveh commented Jan 31, 2024

Great, thanks @mhmd-android

@mhmd-android
Copy link
Contributor

mhmd-android commented Feb 29, 2024

Hi dear @Kaaveh

After a thorough review of the proposed solution to use code generation to address the current issue in the ComposeNews project, I've concluded that this approach might not be the best solution for several reasons:

Limited Utility: While the idea of using a code generator for this specific problem might seem appealing, the truth is that its application would be limited to this particular case only, offering no reusability in other parts of the project or future projects.

Unnecessary Complexity: Introducing a code generation layer into the project could add unwanted complexity. This complexity might complicate code maintenance and understanding for other developers, especially those new to the project.

Focus on More Pragmatic Solutions: It would be more beneficial to explore solutions that enhance the code's maintainability and readability without introducing additional layers that might not add significant value.

Thank you for considering my perspective on this matter.

@Kaaveh
Copy link
Owner Author

Kaaveh commented Feb 29, 2024

@mhmd-android No problem, I think we can close this issue 👍

@Kaaveh Kaaveh closed this as not planned Won't fix, can't repro, duplicate, stale Feb 29, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Compose news Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants