[kmp] Replace Dagger-Hilt with Koin

[Kaaveh]

Replace Dagger-Hilt with Koin

[hadi-norouzi]

Hi @Kaaveh
Can I work on it?

[Kaaveh]

Hey @hadi-norouzi
Sure! 🙌🏻

[hadi-norouzi]

Hi @Kaaveh
I've changed all modules with Koin but I have one issue.
As you have mentioned in the architecture diagram of the project domain:market has a dependency on data:market-repoistory. but in the code, it's not, data:market-repository depend on domain:market.

I've created a Koin module for each module and upper layer modules includes lower modules in their modules like this:

database module:

val localModule = module {
    single { Database() }
}

remote module:

val apiModule = module {
     single { Api() }
}

repository module:

val repositoryModule = module {
    single { Repository(get(), get())
}

I think we need to change the domain:market to be depends on data:market-repository. That's my suggestion.
I would be happy if you could suggest any helpful comment.

[Kaaveh]

This will violate the CLEAN arch. The implementation of the domain layer must be agnostic to the data layer.

[hadi-norouzi]

This will violate the CLEAN arch. The implementation of the domain layer must be agnostic to the data layer.

Yeah we could achieve these by change direction of dependency.

now is:
feature -> domain <- repository.

We could move repository interface to the repository module and only export that interface to domain module.

and change dependencies like this:
feature -> domain -> repository.

I think because of dagger-hilt current arch is possible but it's not possible in koin

[Kaaveh]

This will violate the CLEAN arch. The implementation of the domain layer must be agnostic to the data layer.

Yeah we could achieve these by change direction of dependency.

now is: feature -> domain <- repository.

We could move repository interface to the repository module and only export that interface to domain module.

and change dependencies like this: feature -> domain -> repository.

I think because of dagger-hilt current arch is possible but it's not possible in koin

What do you think @VahidGarousi ?

[VahidGarousi]

@Kaaveh I need a day to review and respond

[Kaaveh]

This will violate the CLEAN arch. The implementation of the domain layer must be agnostic to the data layer.

Yeah we could achieve these by change direction of dependency.

now is: feature -> domain <- repository.

We could move repository interface to the repository module and only export that interface to domain module.

and change dependencies like this: feature -> domain -> repository.

I think because of dagger-hilt current arch is possible but it's not possible in koin

Hey @hadi-norouzi
I spent more time on this issue to understand it. I wonder why you want to invert the dependency between the data and domain modules. Is there any problem with Koin?
According to Dependency Inversion in SOLID, I put the Repository interface in the domain module and all use-cases depend on the interface.

[hadi-norouzi]

This will violate the CLEAN arch. The implementation of the domain layer must be agnostic to the data layer.

Yeah we could achieve these by change direction of dependency.
now is: feature -> domain <- repository.
We could move repository interface to the repository module and only export that interface to domain module.
and change dependencies like this: feature -> domain -> repository.
I think because of dagger-hilt current arch is possible but it's not possible in koin

Hey @hadi-norouzi I spent more time on this issue to understand it. I wonder why you want to invert the dependency between the data and domain modules. Is there any problem with Koin? According to Dependency Inversion in SOLID, I put the Repository interface in the domain module and all use-cases depend on the interface.

Do you agree with me if we want to provides each dependencies in each module we need to have koin module for each android module like this:

val localModule = module {
    single { Database() }
}

val apiModule = module {
     single { Api() }
}

and upper layers should first include lower module and after that provides their dependencies like this:

val repositoryModule = module {
    include(localModule, apiModule)
    single { Repository(local = get(), api = get())
}

So repository module needs to import local and api modules.
Until repository module it's OK, but when we need to includes repository koin module in domain module it can't because domain is not depend on repository and have no access to that.

Another solution

We could import domain and data modules in app module and in koinStart function first include data module and blow that includes domain module.

startKoin {
    modules(dataModule, domainModule)
} 

[Kaaveh]

@hadi-norouzi
Use cases are used in viewModels. I think at least it can be provided in the feature modules.

[rezazarchi]

I was looking for this issue to help if it is pending on something. I have a suggestion for your problem. Put your Koin modules into feature modules. Each feature module depends on core domain and also data modules, which give us reference to our needed classes. With such an arrangement, you can access modules in the app module to include them in the startKoin scope of the ComposeNewsApplication.
By the way, I saw domain:market module was added in app module dependencies. so i don't know what's the problem here.

[Kaaveh]

I saw domain:market module was added in app module dependencies. so i don't know what's the problem here.

@rezazarchi

I think it's due to the support for larger screens. It needs refactoring soon.

[Kaaveh]

@hadi-norouzi
Can you proceed or still have problems?

[rezazarchi]

I saw domain:market module was added in app module dependencies. so i don't know what's the problem here.

@rezazarchi

I think it's due to the support for larger screens. It needs refactoring soon.

We can refactor multi-screens using the new adaptive-layout and adaptive-navigation-suite libraries later.
(Which I know this is off-topic, so let's discuss it in another related issue.)

[Kaaveh]

I saw domain:market module was added in app module dependencies. so i don't know what's the problem here.

@rezazarchi
I think it's due to the support for larger screens. It needs refactoring soon.

We can refactor multi-screens using the new adaptive-layout and adaptive-navigation-suite libraries.

Ya, Currently I'm working on refactoring the whole project in the next few days.

[hadi-norouzi]

I was looking for this issue to help if it is pending on something. I have a suggestion for your problem. Put your Koin modules into feature modules. Each feature module depends on core domain and also data modules, which give us reference to our needed classes. With such an arrangement, you can access modules in the app module to include them in the startKoin scope of the ComposeNewsApplication. By the way, I saw domain:market module was added in app module dependencies. so i don't know what's the problem here.

Yes, you are right. It's the solution.

[Kaaveh]

Hey @hadi-norouzi ,
I'd like to ping you and ask about your progress on this task.