Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export features of hidapi #69

Open
eduidl opened this issue Dec 25, 2021 · 1 comment · Fixed by #70
Open

Re-export features of hidapi #69

eduidl opened this issue Dec 25, 2021 · 1 comment · Fixed by #70
Labels
bugfix Fixation of bug

Comments

@eduidl
Copy link

eduidl commented Dec 25, 2021 •
edited
Loading

Hi. I'm writing a program which runs on Ubuntu 20.04 using joycon-rs.

I think it is necessary to change backend of hidapi to solve the issue #65, however it is impossible to control features of indirectly depended crates.
Therefore, I want joycon-rs to re-export features of hidapi.

I tried to implement it like this, and it seems to have worked.

I hope you will consider it. I'm willing to send a PR. Of course, it's ok if there's a better way.
@KaiseiYokoyama
Copy link
Owner

Thank you for sharing your motivation and code, @eduidl 🙏
I believe it is helpful for me and joycon-rs users.

I made a new develop branch develop/v0.7.0.
Please send your PR here.

@KaiseiYokoyama KaiseiYokoyama added the bugfix Fixation of bug label Dec 26, 2021
@eduidl eduidl mentioned this issue Dec 27, 2021
Merged
@KaiseiYokoyama KaiseiYokoyama linked a pull request Dec 27, 2021 that will close this issue
Re-export features of hidapi #70
Merged
@KaiseiYokoyama KaiseiYokoyama mentioned this issue Dec 27, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugfix Fixation of bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-export features of hidapi
2 participants
@KaiseiYokoyama @eduidl