Implement AutocompleteMetadata and add autofills #28
Conversation
|
One thing which has popped up is that there are sometimes multiple different implementations of the same method (For example, CFrame.new()), and they all show up as different autocompletes in the menu. I haven't found a way to merge them together into a list yet, but I believe for Javascript/Typescript, they just use the first available one, then merge the rest as a "(+x overloads)" This could be done, but you would lose the information for the different possible methods, unless ParameterInformation is implemented (#33), where the parameters are grouped into a single list which you can scroll through |
This hides ItemStructs like RobloxScriptConnection or RaycastResult, as they cannot really be used in code
|
New commits should fix all the issues raised, as well as added parantheses autocompletion if its a function - the autocompletion also respects if there are no parameters (#16) I also implemented the Instance.new() snippet within ItemStruct now (not constrained to Instance.new, will read any constraints provided in the AutocompleteMetadata and show Instance name completion - but this is currently only limited to Instance.new() and BrickColor.new()*) *BrickColor.new() has a constraint set to |
|
No worries, the changes should be fixed now |
|
Sorry for the very long delay. This PR works, and it's great, but I'm not a fan of the new Instance.new method. Previously, I could just type "In", see it suggest, press tab, and then it would instantly fill where I could then follow it with the class name. Now, I have to autofill Instance, then dot, then tab new. It's much slower, can you bring the old Instance.new suggestion back in some way? |
|
I've made it change the insert text of |
|
Yes, but you should change the suggestion text as well in that case to make it obvious. |
| for (const paramIndex in func.parameters) { | ||
| if (func.parameters[paramIndex] !== undefined) { | ||
| const param = func.parameters[paramIndex] |
There was a problem hiding this comment.
This should be for (const param of func.parameters)
There was a problem hiding this comment.
I can't actually do this because I need to use the paramIndex later - unless you want me to use for ... of and use Array.findIndex() afterwards?
There was a problem hiding this comment.
You should be able to do something like for (const [paramIndex, param] of Object.entries(func.parameters)).
This PR downloads the AutocompleteMetadata XML dump from the Roblox Client Tracker and then formats it into an output which is easier to use by the rest of the extension.
It also implements the autofill for the LuaLibrary (math, string, table, etc.) and ItemStructs (Vector2, CFrame etc.) which is provided in the dump, as well as providing links to the Developer Reference within the autofill
Closes #13
Closes #6 (See below comments)