Refs #38003 - Fix broken ACS test #11237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris1984
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
ACK works well tested it with a random seed and the one causing an issue:
# Running tests with run options --seed 17658:
........................DEPRECATED: global use of must_include from /home/vagrant/katello/test/actions/katello/repository_test.rb:410. Use _(obj).must_include instead. This will fail in Minitest 6.
.........................................Writing XML reports to /home/vagrant/foreman/jenkins/reports/unit
Finished tests in 5.914260s, 10.9904 tests/s, 28.2368 assertions/s.# Running tests with run options --seed 32408:
...........DEPRECATED: global use of must_include from /home/vagrant/katello/test/actions/katello/repository_test.rb:410. Use _(obj).must_include instead. This will fail in Minitest 6.
......................................................Writing XML reports to /home/vagrant/foreman/jenkins/reports/unit
Finished tests in 5.989994s, 10.8514 tests/s, 27.8798 assertions/s.
65 tests, 167 assertions, 0 failures, 0 errors, 0 skips
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Fixes a test with random failures
Considerations taken when implementing this change?
...
What are the testing steps for this pull request?
See the tests pass here.
Also try the test with different seed values: