Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more options to clean unused strings only, ignore drawables or ig… #29

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add more options to clean unused strings only, ignore drawables or ig… #29

wants to merge 4 commits into from

Conversation

ialmetwally
Copy link

…nore dimensions

@ca77y
Copy link
Contributor

ca77y commented Sep 11, 2015

no tests + breaks existing tests

@philippb
Copy link
Contributor

Hi @ialmetwally
do you have a interest on making sure your changes are tested and don't break our existing tests? Would love to merge it, but we need that do move forward. If not I'd just close this PR.

@ialmetwally
Copy link
Author

@philippb @ca77y I've fixed the tests and modified the script accordingly, feel free to merge if everything is ok

@philippb
Copy link
Contributor

@ialmetwally Thank you!!!

@ca77y
Copy link
Contributor

ca77y commented Nov 17, 2015

@ialmetwally thanks

@philippb
Copy link
Contributor

philippb commented Feb 8, 2016

@ca77y can we make sure we merge this in

@ca77y ca77y self-assigned this Nov 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ca77y ca77y

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ialmetwally @ca77y @philippb