Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make compatible with dart-sass #160

Merged
merged 3 commits into from
Nov 2, 2024
Merged

Conversation

Bubbu0129
Copy link
Contributor

Fix #158.

Copy link
Collaborator

@RalXYZ RalXYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请将 dart-sass 版本指定为 1.79.6

.github/workflows/dev-build.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@RalXYZ
Copy link
Collaborator

RalXYZ commented Nov 1, 2024

image

另外,提醒您关注一下 committer/author 信息;当前的情形可能不符合您的预期
如果您有意为之,则忽略这个提醒

Copy link
Collaborator

@RalXYZ RalXYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RalXYZ
Copy link
Collaborator

RalXYZ commented Nov 1, 2024

image

另外,提醒您关注一下 committer/author 信息;当前的情形可能不符合您的预期 如果您有意为之,则忽略这个提醒

@Bubbu0129 最后再确认下,您确定您这个 pr 里的 committer/author 信息没问题么?没问题我就合入主线了

@RalXYZ RalXYZ added the 🐞 bug fix PR: bug fix label Nov 1, 2024
@Bubbu0129
Copy link
Contributor Author

谢谢提醒!已修改。
Issue 中提到的问题请注意 #158

@RalXYZ RalXYZ merged commit 124924a into Keldos-Li:main Nov 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug fix PR: bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用dart-sass构建失败
3 participants