Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding certain sized images cause the post text to appear incorrectly. #7

Open
Chuunie opened this issue Nov 29, 2018 · 10 comments
Open
Assignees
Labels
bug Something isn't working feature it's not a bug, it's a feature! help wanted Extra attention is needed won't fix This will not be worked on

Comments

@Chuunie
Copy link

Chuunie commented Nov 29, 2018

Here's an example. When expanded the above image causes the text to appear incorrectly, the below image is an example of how the text should appear upon expanding an image.

example

@Chuunie Chuunie changed the title Expanding certain sized images causes post text to appear incorrectly. Expanding certain sized images cause the post text to appear incorrectly. Nov 29, 2018
@KevinParnell KevinParnell self-assigned this Nov 30, 2018
@KevinParnell KevinParnell added bug Something isn't working help wanted Extra attention is needed labels Nov 30, 2018
@KevinParnell
Copy link
Owner

I am unable to reproduce this error. Turned off fixed width as well. Do you mind posting to that exact post so I can see it?

@Chuunie
Copy link
Author

Chuunie commented Nov 30, 2018

Here's another random example. https://boards.4channel.org/c/thread/3288902
I dunno how to link so it scrolls you to the post but it's post 3292929.

@Chuunie
Copy link
Author

Chuunie commented Nov 30, 2018

I just noticed if I resize my window to be smaller than the post box size it does not occur maybe that's why it could be tricky to reproduce. Here's what I mean. The first image my window is maximised and therefore bigger than the post box size, the bug occurs. The second image the window is resized so the post box has to scale a little bit with it, the bug does not occur.
capture1
capture2

@KevinParnell
Copy link
Owner

I am still unable to reproduce it.
screen shot 2018-11-30 at 12 19 49 pm
screen shot 2018-11-30 at 12 20 08 pm
screen shot 2018-11-30 at 12 21 03 pm
screen shot 2018-11-30 at 12 21 43 pm

I'm testing this on my 13in MacBook Pro on Safari right now. I can take a look on my 1080p Windows 10 desktop on Edge and my 1080p Linux ThinkPad on Chrome in a bit. Can I get some more information on your web browser and screen resolution and whatnot?

@KevinParnell KevinParnell added the can't reproduce Unable to reproduce this issue label Nov 30, 2018
@KevinParnell
Copy link
Owner

Can you also send me your 4chanx and oneechan settings? Mine can be found in the GitHub, can you also test the settings I use?

@KevinParnell
Copy link
Owner

Another user in my discord is unable to reproduce this in Firefox and chrome.

@Chuunie
Copy link
Author

Chuunie commented Nov 30, 2018

I'm using chromium Version 70.0.3538.110. I reset all of my 4chan x settings and oneechan to default and then only turned off fit width in oneechan and it still happens. My guess is that it can't be reproduced because of the resolution. Try this one. https://boards.4channel.org/g/thread/68706075 post number 68708604.

@KevinParnell
Copy link
Owner

Hmm, now it did it.
screen shot 2018-11-30 at 2 38 04 pm

I'm not sure what's causing this, how often does it happen? I'll look into this particular case more over break. It seems to be infrequent at least though, but yeah a bit of an annoyance.

@KevinParnell KevinParnell removed the can't reproduce Unable to reproduce this issue label Nov 30, 2018
@Chuunie
Copy link
Author

Chuunie commented Nov 30, 2018

Maybe 1 in 10 images. It seems to be dependant on the aspect ratio and resolution of the image.

@KevinParnell
Copy link
Owner

I have now decided to leave this as a feature.

@KevinParnell KevinParnell added feature it's not a bug, it's a feature! won't fix This will not be worked on labels Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature it's not a bug, it's a feature! help wanted Extra attention is needed won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants