Adding next button to the labeling interface #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make labeling easier, provide the Next task button to allow labelers to iterate through items. Test Plan: Render the interface and should see the next button provided.
lizfaubell
approved these changes
Jul 25, 2024
Comment on lines
+764
to
+766
| // TODO: we should find better way to access the dataManager's Mobx Store | ||
| const taskList = window.dataManager.store.taskStore.list; | ||
| const thisTaskIdx = taskList.findIndex((x) => x.id === self.task.id); |
There was a problem hiding this comment.
Is this the task list for the specific tab we came from? Or all of them?
There was a problem hiding this comment.
Good question! Conveniently this is the list showed in the datamanager table, which is what is in the tab 🎉
I will add a comment on this!
khan-actions-bot
pushed a commit
to Khan/label-studio
that referenced
this pull request
Jul 25, 2024
…17e81b6c3591a9be48a61ceea3cf22e3e6ca at Khan/label-studio-frontend#12 Workflow run: https://github.com/Khan/label-studio/actions/runs/10102860360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To make labelling easier, provide the Next task button to allow labellers to iterate through items.
Note that normally one would use the "Label tasks as displayed" feature, but that turns out to be
not working as expected - at most it will give label of ~10 tasks from our testing.
Note that we create a separate button, instead of part of the "Submit" because submitting require
an async operation to data manager which makes it hard to know when that's done, before jumping
to next task.
Test Plan
Render the interface, and you should see the next button provided.