Fix MathJax rendering #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR deals with the following rendering issue: * Multiple dollar signs in MathJax expression lead to mistaken MathJax rendering - Thread ID: 1a78652b351779b476903c9966ef2c455fc244f2 - Test task URL: https://data-labeling-test.khanacademy.org/projects/314/data?tab=624&page=1&task=108725 * `/begin{}` and `\end{}` always trigger rendering dispite Marker not exists. This lead to bad selection threads. - Thread ID: 032e483505cd43f2bee52184b4dbec57db559681 - Test task URL: https://data-labeling-test.khanacademy.org/projects/314/data?tab=624&page=1&task=108659 This PR suppress that by adding `ignoreClass`, as well as removing unnecessary `no display` tags which also simplifies the rendering. Issue: https://khanacademy.atlassian.net/browse/DI-1514 Test Plan: Open the above threads and confirm that the MathJax rendering behaves correctly.
khan-actions-bot
pushed a commit
to Khan/label-studio
that referenced
this pull request
Jul 31, 2024
…8f3de2c341cde25b73bf97af2e8de06f7dfa at Khan/label-studio-frontend#14 Workflow run: https://github.com/Khan/label-studio/actions/runs/10187563969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR deals with the following rendering issue:
Multiple dollar signs in MathJax expression lead to mistaken MathJax rendering
/begin{}and/end{}always trigger rendering dispite Marker not exists. This lead to bad selection threads.This PR suppress that by adding
ignoreHtmlClass.Issue: https://khanacademy.atlassian.net/browse/DI-1514
Test Plan
Open the above threads and confirm that the MathJax rendering behaves correctly.
The dev server
yarn startshould also show this.Before fix - misrendering highlighted