-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add visible label and ARIA label to Dropdown widget #1845
Draft
daniellewhyte
wants to merge
18
commits into
main
Choose a base branch
from
add-dropdown-labels
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (c214bc5) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1845 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1845 |
Size Change: +336 B (+0.03%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit adds two new fields to the Dropdown widget:
ariaLabel
andvisibleLabel
.Issue: LIT-1424
Test plan:
Visual inspection (visibleLabel):
You can also see examples in the course editor on this ZND: https://prod-znd-241121-danielle-dw1.khanacademy.org/devadmin/content/articles/dropdown-with-labels/x56e2ea23d30e405c
Screen reader walkthrough with both
ariaLabel
andvisibleLabel
defined:Screen reader walkthrough with
ariaLabel
defined andvisibleLabel
undefined:(This will probably be most instances as the dropdown widget is mostly used inline, and the visible label makes things too cramped.)