Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visible label and ARIA label to Dropdown widget #1845

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

daniellewhyte
Copy link
Contributor

@daniellewhyte daniellewhyte commented Nov 12, 2024

Summary:

This commit adds two new fields to the Dropdown widget: ariaLabel and visibleLabel.

Issue: LIT-1424

Test plan:

Visual inspection (visibleLabel):

You can also see examples in the course editor on this ZND: https://prod-znd-241121-danielle-dw1.khanacademy.org/devadmin/content/articles/dropdown-with-labels/x56e2ea23d30e405c

Screen reader walkthrough with both ariaLabel and visibleLabel defined:

Screen reader walkthrough with ariaLabel defined and visibleLabel undefined:
(This will probably be most instances as the dropdown widget is mostly used inline, and the visible label makes things too cramped.)

@daniellewhyte daniellewhyte self-assigned this Nov 12, 2024
Copy link
Contributor

github-actions bot commented Nov 12, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (c214bc5) and published it to npm. You
can install it using the tag PR1845.

Example:

yarn add @khanacademy/perseus@PR1845

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1845

Copy link
Contributor

github-actions bot commented Nov 12, 2024

Size Change: +336 B (+0.03%)

Total Size: 1.29 MB

Filename Size Change
packages/perseus-editor/dist/es/index.js 698 kB +114 B (+0.02%)
packages/perseus/dist/es/index.js 425 kB +222 B (+0.05%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.9 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.57 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant