Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotter: Extract validation out of scoring #1899

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Myranae
Copy link
Contributor

@Myranae Myranae commented Nov 21, 2024

Summary:

To complete server-side scoring, we are separating out validation logic from scoring logic. This PR separates that logic and associated tests for the plotter widget.

Issue: LEMS-2604

Test plan:

  • Confirm checks pass
  • Confirm widget still works as expected

@Myranae Myranae self-assigned this Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (c75de6d) and published it to npm. You
can install it using the tag PR1899.

Example:

yarn add @khanacademy/perseus@PR1899

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1899

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Size Change: +177 B (+0.01%)

Total Size: 1.29 MB

Filename Size Change
packages/perseus/dist/es/index.js 425 kB +177 B (+0.04%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.9 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-editor/dist/es/index.js 698 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.57 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@Myranae Myranae marked this pull request as ready for review November 21, 2024 19:22
@khan-actions-bot
Copy link
Contributor

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/nice-fans-swim.md, packages/perseus/src/validation.types.ts, packages/perseus/src/widgets/plotter/plotter.tsx, packages/perseus/src/widgets/plotter/score-plotter.test.ts, packages/perseus/src/widgets/plotter/score-plotter.ts, packages/perseus/src/widgets/plotter/validate-plotter.test.ts, packages/perseus/src/widgets/plotter/validate-plotter.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@khan-actions-bot khan-actions-bot requested a review from a team November 21, 2024 19:22
Comment on lines 14 to 15
* @param userInput
* @param validationData
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these. They don't add any new information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants