-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotter: Extract validation out of scoring #1899
base: main
Are you sure you want to change the base?
Conversation
Also refactor the scoring function to not need the helper functions and rename rubric.
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (c75de6d) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1899 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1899 |
Size Change: +177 B (+0.01%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
* @param userInput | ||
* @param validationData |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove these. They don't add any new information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed!
Summary:
To complete server-side scoring, we are separating out validation logic from scoring logic. This PR separates that logic and associated tests for the plotter widget.
Issue: LEMS-2604
Test plan: