Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings for removals in Khiops V11 #176

Closed
folmos-at-orange opened this issue Apr 10, 2024 · 2 comments · Fixed by #211
Closed

Add deprecation warnings for removals in Khiops V11 #176

folmos-at-orange opened this issue Apr 10, 2024 · 2 comments · Fixed by #211
Assignees
Labels
Status/Done The issue has been addressed and merged to the dev branch Type/Feature A new feature request or an improvement of a feature
Milestone

Comments

@folmos-at-orange
Copy link
Member

folmos-at-orange commented Apr 10, 2024

Description

Some features will be removed in Khiops V11, we should alert from the next minor releases of khiops-python of their future removal.

Questions/Ideas

@folmos-at-orange folmos-at-orange added Priority/0-High To do now Type/DevChore Repository maintainance, CI/CD or non user-facing refactorings Type/Feature A new feature request or an improvement of a feature Status/Draft The issue is still not well defined and removed Type/DevChore Repository maintainance, CI/CD or non user-facing refactorings labels Apr 10, 2024
@folmos-at-orange folmos-at-orange added Status/ReadyForDev The issue is ready to be developed or to be investigated deeply Status/InDevelopment The issue is in development by one or more team members and removed Status/Draft The issue is still not well defined Status/ReadyForDev The issue is ready to be developed or to be investigated deeply labels Jul 11, 2024
@folmos-at-orange
Copy link
Member Author

Deprecation list

  • discretization_method:
    • Values EqualWidth and EqualFrequency deprecated for supervised learning
  • grouping_method:
    • Values BasicGrouping deprecated for supervised learning
  • min_group_frequency
  • min_interval_frequency
  • max_groups
    • replaced by max_parts
  • max_intervals
    • replaced by max_parts
  • results_dir: Is deprecated without message because it is mandatory and it will be renamed to report_file_path
  • results_prefix
    • replaced by report_file_path

@marcboulle
Copy link

Compléments à la deprecation list

  • snb_predictor
  • univariate_predictor_number

Précisions:

  • pour discretization_methodet grouping_method en supervisé, toutes les valeurs sont deprecated, y compris MOL
  • pour results_dir et results_prefix, il faudra gérer les utilisation existante de type directory, alors qu'en V11, un nom de directory sera interdit

Cf. KhiopsML/khiops#223 (comment)

  • removed fields:
    • "Selective Naive Bayes": trained, except if "Do data preparation only" is triggered
    • "Baseline predictor": never used in classification, always provided in regression
    • "Number of univariate predictors": supressed

@folmos-at-orange folmos-at-orange added Status/Done The issue has been addressed and merged to the dev branch and removed Status/InDevelopment The issue is in development by one or more team members labels Jul 19, 2024
@folmos-at-orange folmos-at-orange added this to the 10.2.2.2 milestone Jul 31, 2024
@folmos-at-orange folmos-at-orange removed the Priority/0-High To do now label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status/Done The issue has been addressed and merged to the dev branch Type/Feature A new feature request or an improvement of a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants