From 05397aeb4a76799522f7b30030a6822543868cfb Mon Sep 17 00:00:00 2001 From: Felipe Olmos Date: Thu, 2 Nov 2023 14:35:03 +0100 Subject: [PATCH] Fix MODL_Coclustering double size in windows The MODL_Coclustering.exe executable in windows had doubled in size because the MSVC link option `/INCREMENTAL` was activated. This wasn't the case for the original build with VS projects. --- src/Learning/MODL_Coclustering/CMakeLists.txt | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/src/Learning/MODL_Coclustering/CMakeLists.txt b/src/Learning/MODL_Coclustering/CMakeLists.txt index 97cb92dd5..8c433e51f 100644 --- a/src/Learning/MODL_Coclustering/CMakeLists.txt +++ b/src/Learning/MODL_Coclustering/CMakeLists.txt @@ -1,15 +1,11 @@ file(GLOB cppfiles ${CMAKE_CURRENT_SOURCE_DIR}/*.cpp) -# on fedora, binaries built with mpi must ended by _mpich suffix +# MODL_Coclustering target On Fedora: binaries built with MPI must suffixed by _mpich (stored in ${MPI_SUFFIX}) add_executable(MODL_Coclustering${MPI_SUFFIX} ${cppfiles} MODL_Coclustering.rc) -set_khiops_options(MODL_Coclustering${MPI_SUFFIX}) - target_link_libraries(MODL_Coclustering${MPI_SUFFIX} PUBLIC KMDRRuleLibrary KWLearningProblem) +set_khiops_options(MODL_Coclustering${MPI_SUFFIX}) -if(MSVC) - target_link_options(MODL_Coclustering${MPI_SUFFIX} PUBLIC "/INCREMENTAL") -endif() - +# MODL_SO target (shared library) add_library(MODL_Coclustering_SO SHARED ${cppfiles}) target_link_libraries(MODL_Coclustering_SO PUBLIC KMDRRuleLibrary KWLearningProblem) set_target_properties(