[SPIR-V 1.2] SPIRVReader: Add AlignmentId support #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrSidims
approved these changes
Nov 20, 2024
svenvh
commented
Nov 22, 2024
lib/SPIRV/libSPIRV/SPIRVValue.cpp
Outdated
| SPIRVId AlignId; | ||
| bool HasDecorateId = hasDecorateId(DecorationAlignmentId, 0, &AlignId); | ||
| if (HasDecorateId) { | ||
| SPIRVConstant *Cst = Module->get<SPIRVConstant>(AlignId); |
There was a problem hiding this comment.
This doesn't work with specialization constants, I'll upload a new version of this patch.
If there is no `OpDecorate .. Alignment` in the input, see if there is an `OpDecorateId .. AlignmentId` and take the alignment from the referenced constant instead. Once `AlignmentId` has been translated to LLVM IR, it is indistinguishable from an (non-ID) `Alignment` decoration.
svenvh
force-pushed
the
opdecorateid-alignmentid
branch
from
8d23bf5
to
40d9509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no
OpDecorate .. Alignmentin the input, see if there is anOpDecorateId .. AlignmentIdand take the alignment from the referenced constant instead.Once
AlignmentIdhas been translated to LLVM IR, it is indistinguishable from an (non-ID)Alignmentdecoration.