Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec change] Add shorthand aliases for address spaces #952

Open
sycl-issue-bot bot opened this issue Sep 27, 2024 · 3 comments
Open

[Spec change] Add shorthand aliases for address spaces #952

sycl-issue-bot bot opened this issue Sep 27, 2024 · 3 comments

Comments

@sycl-issue-bot
Copy link

Please review whether KhronosGroup/SYCL-Docs#633 by @Pennycook requires any changes to the CTS.

If changes are required: Open a new PR addressing the changes and link it to this issue.
If no changes are required: Close this issue and proceed with the spec PR.

@Pennycook
Copy link
Contributor

This change requires new tests, but they're very simple:

  • Check that sycl::addrspace and sycl::access::address_space refer to the same type.
  • Check that sycl::addrspace_global == sycl::addrspace::global_space.
  • Check that sycl::addrspace_local == sycl::addrspace::local_space.
  • Check that sycl::addrspace_private == sycl::addrspace::private_space.
  • Check that sycl::addrspace_generic == sycl::addrspace::generic_space.

@tomdeakin
Copy link
Contributor

Will also need a SYCL Next macro in CTS.

@psalz
Copy link
Contributor

psalz commented Dec 5, 2024

Will also need a SYCL Next macro in CTS.

Something along the lines of SYCL_CTS_ENABLE_KHR_TESTS would probably work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants