Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specializations of std::hash for all the structs and handles in the vk-namespace. #1994

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

asuessenbach
Copy link
Contributor

Resolves #1943.

@sharadhr
Copy link
Contributor

This looks reasonable to me. @stripe2933 I don't have another compiler at hand to test—would you be able to chime in as well?

@stripe2933
Copy link

Tested on Clang 18 and MSVC 14.42. Here's the CI link.

  • Clang is not affected by this patch (std::hash<(vulkan-type)>s are implicitly exported by its module implementation nature.
  • MSVC affected by this patch. Patch before Patch after

Thank for your efforts.

@asuessenbach
Copy link
Contributor Author

@stripe2933, @sharadhr: Thanks a lot for your help with this issue!

@asuessenbach asuessenbach merged commit cdfa83a into KhronosGroup:main Nov 26, 2024
22 checks passed
@asuessenbach asuessenbach deleted the hash branch November 26, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<vulkan/vulkan_hash.hpp> included in vulkan.cppm but std::hash specializations are not exported.
3 participants