Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate updated antora-lunr search once merged there #57

Open
oddhack opened this issue Dec 8, 2023 · 3 comments
Open

Incorporate updated antora-lunr search once merged there #57

oddhack opened this issue Dec 8, 2023 · 3 comments
Assignees
Labels
antora Fix or extension to antora behavior needed enhancement New feature or request navigation improve site navigation search improve search
Milestone

Comments

@oddhack
Copy link
Collaborator

oddhack commented Dec 8, 2023

Tracking issue for search: @gpx1000 came up with a big improvement which we currently incorporate into our build environment, and someone was kind enough to boost that into an MR in the antora-lunr repo: https://gitlab.com/antora/antora-lunr-extension/-/merge_requests/93 . Once that is merged and published in a package update, we should migrate over to the upstreamed fix and stop using the local one.

@oddhack oddhack self-assigned this Dec 8, 2023
@oddhack oddhack added the enhancement New feature or request label Dec 8, 2023
@oddhack oddhack added navigation improve site navigation search improve search antora Fix or extension to antora behavior needed labels Jan 29, 2024
@oddhack oddhack added this to the Needs Action/MR milestone Jan 30, 2024
@oddhack
Copy link
Collaborator Author

oddhack commented Jan 30, 2024

This is deferred pending the antora-lunr PR being merged and an updated package published.

@oddhack oddhack modified the milestones: Needs Action/MR, Deferred Jan 30, 2024
@oddhack
Copy link
Collaborator Author

oddhack commented Jul 1, 2024

@gpx1000 note that https://gitlab.com/antora/antora-lunr-extension/-/issues/61 has resolving this issue as the only blocker on an antora-lunr 1.0.0 release. Not sure what they would need to move forward (probably time more than anything else, that has been pending for 8 months). But you might check in on that issue or on https://gitlab.com/antora/antora-lunr-extension/-/merge_requests/93 where the MR exists and see if there's something that would help progress it.

If you are still having trouble with ssh keys and gitlab.com access, I or @khronos2 could likely assist with that. But you could comment with just a gitlab.com login, even if you cannot pull the repository.

@oddhack
Copy link
Collaborator Author

oddhack commented Oct 7, 2024

I checked on this - it appears held up partly because the third party MR https://gitlab.com/antora/antora-lunr-extension/-/merge_requests/93 based on @gpx1000's work has fallen out of date. Pinged to see if that could be done, or I could do it instead in a new MR, because accepting that MR unblocks a chain of events that should allow an antora-lunr 1.0 release including these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
antora Fix or extension to antora behavior needed enhancement New feature or request navigation improve site navigation search improve search
Projects
None yet
Development

No branches or pull requests

1 participant