layers: Do not create wait timepoint after signal retired #9004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 322262. |
|
CI Vulkan-ValidationLayers build # 18295 running. |
artem-lunarg
commented
Dec 11, 2024
| } | ||
|
|
||
| if (payload <= completed_.payload) { |
There was a problem hiding this comment.
Previously this was only for timeline semaphores. The test shows it's also needed for binary semaphores.
|
CI Vulkan-ValidationLayers build # 18295 aborted. |
|
CI Vulkan-ValidationLayers build queued with queue ID 322458. |
|
CI Vulkan-ValidationLayers build # 18301 running. |
|
CI Vulkan-ValidationLayers build # 18301 aborted. |
This is follow-up to 8a41fe2 - Fix empty timeline assumption in Semaphore::EnqueueWait Wait timepoint should not be registered when signal is already retired. In this case wait should be resolved againt completed_ state. There is assert in Semaphore::CanBinaryBeSignaled that checks that binary timepoint has at least signal op. The new tests will trigger this assert in case of a regression.
artem-lunarg
force-pushed
the
artem-semaphore-wait-update
branch
from
b6ea498 to
5b01c31
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 322681. |
|
CI Vulkan-ValidationLayers build # 18310 running. |
spencer-lunarg
approved these changes
Dec 12, 2024
|
CI Vulkan-ValidationLayers build # 18310 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up to #9000 and reproduces another assert #8989 (comment)
Wait timepoint should not be registered when signal is already retired.
In this case wait should be resolved againt
completed_state.There is assert in
Semaphore::CanBinaryBeSignaledthat checks thatbinary timepoint has at least signal op. The new tests will trigger this
assert in case of a regression.
There might be other places to adjust, will continue to inspect code.
Addresses assert part of #9009