tests: Remove invalid positive array layer tests #9006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 322364. |
spencer-lunarg
commented
Dec 12, 2024
| @@ -93,79 +93,3 @@ TEST_F(PositiveGpuAVImageLayout, DescriptorArrayLayout) { | |||
| m_default_queue->Submit(m_command_buffer); | |||
| m_default_queue->Wait(); | |||
| } | |||
|
|
|||
| // Waiting to hear from https://gitlab.khronos.org/vulkan/vulkan/-/issues/4110 | |||
| TEST_F(PositiveGpuAVImageLayout, DISABLED_MultiArrayLayers) { | |||
There was a problem hiding this comment.
we have negative variation of the tests already when these were added
|
CI Vulkan-ValidationLayers build # 18297 running. |
|
CI Vulkan-ValidationLayers build # 18297 passed. |
artem-lunarg
approved these changes
Dec 12, 2024
Where is this specified? What is the exact, formal, requirement? At face value, this seems to make it impossible to stream layers in an array texture concurrently with rendering, which is a painful constraint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1998
from #8982
Was discussed in https://gitlab.khronos.org/vulkan/vulkan/-/issues/4110 that all image array layers in a single ImageView must be valid if any part of the descriptor is accessed. While this might not effect drivers that don't care about Image Layout, those that do care said this likely will break and the advice to either
VK_EXT_descriptor_bufferthere is actually adescriptorBufferImageLayoutIgnoredfeature that was designed for things like thiscc @Ralith