Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL for reporting issues. #70

Open
vpenades opened this issue Oct 22, 2020 · 3 comments
Open

Add URL for reporting issues. #70

vpenades opened this issue Oct 22, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@vpenades
Copy link

vpenades commented Oct 22, 2020

Right now, for every project there's only one URL that points to the project's main site.

If possible, I would like the table to include these entries:

  • An URL for issue reporting, if available.
  • If the project is an exporter, the generator name prefix, ex: "babylon.js", "Sketchfab" , etc.

These two entries could be useful to add this functionality:

When an importer validates a glTF and finds errors, it can use the "generator" entry to find the project that produced the asset, and from there, report the Issue notification URL.

In other words, what I want to do is, when I load a glTF with errors, to be able to tell the user:

The file xxxxx.gltf is malformed.
Errors found: ....
Warnings found ....
Please, report these issues to http://www.somefancygltfexporter.com/issuereporting.html

Notice that, although many projects are reported as "exporters", under the hood they're using some other third party exporter, in these cases, I would either don't set the "generator", or I would point to the actual project that exports the asset as a dependency.

@donmccurdy
Copy link

+1 for this suggestion — ideally we should also include the generator string for exporters, perhaps as a glob like "FBX2GLTF *". This would enable viewers to look up the exporter for a given glTF file and match it to the bug URL. My viewer does this now, although I haven't done a great job of pushing the feature:

Screen Shot 2020-10-22 at 9 57 39 AM

We could probably just merge https://github.com/KhronosGroup/glTF-Generator-Registry into this project, if we want to go down that path. There's not much incentive for exporters to add themselves to the generator registry, whereas there is actual incentives to register here, so I expect we'll get much more traction.

@weegeekps weegeekps self-assigned this Oct 22, 2020
@weegeekps
Copy link
Contributor

I like this idea. Give me a few days and I will figure out how best for us to handle this.

To be clear, what I'm looking at is adding:

  • A field that projects can use for providing a link for issue reporting.
  • A field that specifies the generator name prefix.

I'm also open to us merging the data from https://github.com/KhronosGroup/glTF-Generator-Registry as well, but it might be worthwhile to have a discussion about what fields we need. Perhaps, a topic for next weeks call?

@vpenades
Copy link
Author

vpenades commented Oct 22, 2020

If possible, I would like the list to handle non public projects; for example, sketchfab might probably don't have an entry, but I would like it to be included, so bugs can be reported to their forums

@weegeekps weegeekps added the enhancement New feature or request label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants