Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Silk, pad overlap seems to be unreliable #254

Open
poeschlr opened this issue Aug 20, 2018 · 2 comments
Open

Silk, pad overlap seems to be unreliable #254

poeschlr opened this issue Aug 20, 2018 · 2 comments

Comments

@poeschlr
Copy link
Collaborator

I did not yet find time to investigate this in more detail. It reported an overlap between silk an pad in this PR even thought the effected pads have clearance between silk and pads.
KiCad/kicad-footprints#839

@zgyarmati
Copy link
Contributor

This one also hit me, but from a different angle, on my footprint the script didn't report the overlap between the silkscreen and the pad, see here: KiCad/kicad-footprints#1558 (comment)
See this version of the footprint in question:
https://github.com/KiCad/kicad-footprints/blob/e52d325004eb2c6c4035ef20e5efcefed5f1e4a9/Connector_BarrelJack.pretty/BarrelJack_Lumberg_1613-14_15_SMT_Horizontal.kicad_mod

I started to look into the
pcb/rules/F5_1.py' checkIntersections method, but before diving into it too deep, i need to ask:
Would it be possible to depend on external libs in the scriptset? For the intersection checking (but i think also at other places in the scripts) it would be handy to use shapely ( https://pypi.org/project/Shapely/ ) or other geometric lib.

@evanshultz
Copy link
Collaborator

I think, at this time, we'd prefer to limit dependencies. Do you have some suggestions without adding any? If you feel the checking for this rule, at least, cannot be substantially or easily improved without adding an external lib then that is good info to share with us as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants