Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

S4.3 pin stacking not reliable enough #308

Open
karlp opened this issue Jul 3, 2019 · 2 comments
Open

S4.3 pin stacking not reliable enough #308

karlp opened this issue Jul 3, 2019 · 2 comments

Comments

@karlp
Copy link

karlp commented Jul 3, 2019

It isn't reliable enough to be considered a "failure" (yet?) so it's not looked at by submitters, "all checks are green" And when you do read the suggestions, it just says, "power in/out should not be invisible" It doesn't mention the other option, "should this pin be passive?"

https://github.com/KiCad/kicad-library-utils/blob/master/schlib/rules/S4_3.py#L135 is correctly idenfitying the "power in/out+passive" stack that's required, when it's correct, but it doesn't suggest it as a solution when it's wrong.

@poeschlr
Copy link
Collaborator

Was the invisible power input pin already stacked? Because that is the only case where we could make this suggestion. If it is not stacked then the error is that it is invisible. If it is stacked then the error is that it has potentially the wrong type.

@karlp
Copy link
Author

karlp commented Aug 19, 2019

yes, because I'd attempted to get the stack right.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants