Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting for connections terminated remotely. #26

Open
icorderi opened this issue Nov 25, 2014 · 0 comments
Open

Improve error reporting for connections terminated remotely. #26

icorderi opened this issue Nov 25, 2014 · 0 comments

Comments

@icorderi
Copy link
Member

When a handshake status is not SUCCESS and the drive proceeds to terminate the connection the client returns Connection closed by peer instead of the error cause informed by the drive.

  • A specific DeviceLocked error should be added.
  • DEVICE_LOCKED is a valid status code on secure connections and does not cause the socket to be closed.
  • A client should fail during connect() with DeviceLocked if the device returns status DEVICE_LOCKED and the connection is not secured.
  • The generic RemoteError(STATUS_CODE) should be returned with any other status that is not SUCCESS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant