Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support Modrinth Resource Packs #127

Open
null511 opened this issue Sep 26, 2024 · 1 comment
Open

[Enhancement] Support Modrinth Resource Packs #127

null511 opened this issue Sep 26, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@null511
Copy link

null511 commented Sep 26, 2024

Current Behavior

Publishing a resource pack to Modrinth fails
image

Desired Behavior

May not be related, but it's currently not possible to omit the "loaders" field when publishing resource packs to modrinth, even though the web form doesn't support that field.

Alternative Solutions

No response

Other Information

returning from shaders support: #52

@null511 null511 added the enhancement New feature or request label Sep 26, 2024
@Kir-Antipov
Copy link
Owner

Oh, wow, it's already been a year. To be quite frankly honest with you, I don't have anything new to add compared to #52 (comment):

  • mc-publish doesn't support resource packs, modpacks, etc., only in the sense that it doesn't currently perform automagic value resolution for certain properties like it does for mods.
  • You can still use mc-publish if you provide those values manually, as in this case, mc-publish merely serves as a unified wrapper over the GitHub/CurseForge/Modrinth APIs.
  • I'm wrapping up work on full-featured support for different project types.

In your case, the Modrinth API is complaining about loaders.length being 0 (because whatever you specify in the loaders field will be automatically filtered out if your project type doesn't support it). Labrinth always requires this field to be populated, even though this may be hidden from you in their web interface. So, let's go back to Modrinth's /tag/loader endpoint. If you inspect its response, you'll see that the value Modrinth expects from you is minecraft. It's as simple as that:

loaders: minecraft

Once full support for more project types is upstreamed from my local efforts, mc-publish will be able to supply that value for you automatically. Unfortunately, it doesn't know how to handle that just yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants