-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent full re-render on final KCL file deletion #3808
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Nice I thought the original did what the new does :D |
This might have a real playwright failure https://github.com/KittyCAD/modeling-app/actions/runs/10729880216/job/29759277503?pr=3808#step:20:19343 |
I suspect the error is caused by a race in Windows (I just ran it again and 1 of 2 of the failed tests passed) |
I'm going to look for Recording.2024-09-16.182853.mp4 |
It's so annoying and strange, I do not understand why things are so different from this one character change |
Interesting, I am very wrong about my original idea 😆 Ok, this is good! I think this is way more tangible. I can help with this tomorrow 100% |
Thank you! I do not get it, it's not the |
I'll put this over the line; just leave it to me so you can get it off your mind |
FYI I have not forgotten about this. It's related to the file related stuff so I'm saving it for then. |
I'm gonna close this because it's stale, it's easy to resurrect, and it overlaps with the class of bugs you're squashing with your project view work. |
@JordanNoone pointed out that there was a "crash" or something wrong when deleting the final KCL file in a project's top directory. This was a full refresh that felt more catastrophic in dark mode due to a separate issue fixed by #3794. But react-router-dom's navigation should prevent a full re-render of the page anyway, so I investigated and found the very smol cause.
Demo
Screenshare.-.2024-09-05.5_49_38.PM-compressed.mp4