Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent full re-render on final KCL file deletion #3808

Closed
wants to merge 10 commits into from

Conversation

franknoirot
Copy link
Collaborator

@franknoirot franknoirot commented Sep 5, 2024

@JordanNoone pointed out that there was a "crash" or something wrong when deleting the final KCL file in a project's top directory. This was a full refresh that felt more catastrophic in dark mode due to a separate issue fixed by #3794. But react-router-dom's navigation should prevent a full re-render of the page anyway, so I investigated and found the very smol cause.

Demo

Screenshare.-.2024-09-05.5_49_38.PM-compressed.mp4

Copy link

qa-wolf bot commented Sep 5, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Oct 17, 2024 4:19pm

Copy link
Collaborator

@jtran jtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@lf94
Copy link
Contributor

lf94 commented Sep 5, 2024

Nice I thought the original did what the new does :D

@franknoirot
Copy link
Collaborator Author

@lf94
Copy link
Contributor

lf94 commented Sep 16, 2024

I suspect the error is caused by a race in Windows (I just ran it again and 1 of 2 of the failed tests passed)

@franknoirot
Copy link
Collaborator Author

I'm going to look for /main.kcl somewhere in the codebase, I think something about this change generates a Unix-style path

Recording.2024-09-16.182853.mp4

@franknoirot
Copy link
Collaborator Author

It's so annoying and strange, I do not understand why things are so different from this one character change

@lf94
Copy link
Contributor

lf94 commented Sep 17, 2024

Interesting, I am very wrong about my original idea 😆

Ok, this is good! I think this is way more tangible. I can help with this tomorrow 100%

@franknoirot
Copy link
Collaborator Author

Thank you! I do not get it, it's not the main.kcl think I was off. It's so weird to me that it's Windows-specific

@lf94
Copy link
Contributor

lf94 commented Sep 19, 2024

I'll put this over the line; just leave it to me so you can get it off your mind

@lf94 lf94 self-assigned this Sep 19, 2024
@lf94
Copy link
Contributor

lf94 commented Sep 24, 2024

FYI I have not forgotten about this. It's related to the file related stuff so I'm saving it for then.

@franknoirot
Copy link
Collaborator Author

I'm gonna close this because it's stale, it's easy to resurrect, and it overlaps with the class of bugs you're squashing with your project view work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants