From 681294ad859d3621d7cd5217d34272964a4b02a2 Mon Sep 17 00:00:00 2001 From: Sean McBride Date: Fri, 17 May 2024 18:23:26 -0400 Subject: [PATCH] COMP: remove suppression of -Winconsistent-missing-override I tested with AppleClang 10, the oldest AppleClang submitting to cdash, and this false positive seems to have been fixed long ago. --- .../Numerics/Statistics/include/itkSubsample.h | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/Modules/Numerics/Statistics/include/itkSubsample.h b/Modules/Numerics/Statistics/include/itkSubsample.h index 9f3ad887a37..2ac3920c79c 100644 --- a/Modules/Numerics/Statistics/include/itkSubsample.h +++ b/Modules/Numerics/Statistics/include/itkSubsample.h @@ -75,15 +75,6 @@ class ITK_TEMPLATE_EXPORT Subsample : public TSample * object */ using InstanceIdentifierHolder = std::vector; -// Disable clang warning false positive. -// -#if defined(__clang__) && defined(__has_warning) -# if __has_warning("-Winconsistent-missing-override") -# pragma clang diagnostic push -# pragma clang diagnostic ignored "-Winconsistent-missing-override" -# endif -#endif - /** Get the Id Holder */ const InstanceIdentifierHolder & GetIdHolder() const @@ -91,12 +82,6 @@ class ITK_TEMPLATE_EXPORT Subsample : public TSample return this->m_IdHolder; } -#if defined(__clang__) && defined(__has_warning) -# if __has_warning("-Winconsistent-missing-override") -# pragma clang diagnostic pop -# endif -#endif - /** Plug in the actual sample data */ void SetSample(const TSample * sample);