Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotation Tool Refactoring #311

Closed
5 tasks done
PaulHax opened this issue Apr 21, 2023 · 2 comments
Closed
5 tasks done

Annotation Tool Refactoring #311

PaulHax opened this issue Apr 21, 2023 · 2 comments
Assignees
@floryst @PaulHax
Milestone
Future

Comments

@PaulHax
Copy link
Collaborator

PaulHax commented Apr 21, 2023 •
edited
Loading

  • In all stores, replace Pinia plugin injected this.$id with a new ID focused store.
  • For RectangleWidget2D.vue and RulerWidget2D.vue, factor out shared logic to composables.
  • For RectangleTool.vue and RulerTool.vue, factor out shared logic to composables.

Other opportunities
@aylward aylward added this to the Future milestone Jul 24, 2023
@PaulHax
Copy link
Collaborator Author

PaulHax commented Jul 31, 2023

Polygon Tool PR #376 introduces AnnotationToolStore type which will help here.

@PaulHax
Copy link
Collaborator Author

PaulHax commented Sep 22, 2023

Good progress via #421

@PaulHax PaulHax closed this as completed Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@floryst floryst

@PaulHax PaulHax

Labels
None yet
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@aylward @floryst @PaulHax